Enable gpu_times for all platforms other than windows.

Enable gpu_times for all platforms other than windows.

R=nednguyen@google.com
BUG=453131, 455292
Committed: https://crrev.com/95325bb92cdce4b3c4fd93ae3509e72f89536c9c
Cr-Commit-Position: refs/heads/master@{#322273}

[David Yen, 2015-03-24 17:30:36]

dyen@chromium.org changed reviewers:
+ nednguyen@google.com
- nednguyen@chromium.org

[David Yen, 2015-03-24 17:30:56]

On 2015/03/24 17:30:18, David Yen wrote:

Let's try enabling this and keep a close watch.

[nednguyen, 2015-03-24 17:37:59]

On 2015/03/24 17:30:56, David Yen wrote:
> On 2015/03/24 17:30:18, David Yen wrote:
> 
> Let's try enabling this and keep a close watch.

Can you run a tryjob to make sure before we land this? :-)

[sullivan, 2015-03-24 18:16:07]

On 2015/03/24 17:37:59, nednguyen wrote:
> On 2015/03/24 17:30:56, David Yen wrote:
> > On 2015/03/24 17:30:18, David Yen wrote:
> > 
> > Let's try enabling this and keep a close watch.
> 
> Can you run a tryjob to make sure before we land this? :-)

+1 for tryjob and also mailing perf-sheriffs@chromium.org to notify.

[David Yen, 2015-03-24 18:20:03]

On 2015/03/24 18:16:07, sullivan wrote:
> On 2015/03/24 17:37:59, nednguyen wrote:
> > On 2015/03/24 17:30:56, David Yen wrote:
> > > On 2015/03/24 17:30:18, David Yen wrote:
> > > 
> > > Let's try enabling this and keep a close watch.
> > 
> > Can you run a tryjob to make sure before we land this? :-)
> 
> +1 for tryjob and also mailing mailto:perf-sheriffs@chromium.org to notify.

Added perf sheriffs to CC list, triggered try jobs.

Perf Sheriffs, I am enabling a perf test that has been known to be flaky in the
past. We have sorted out most of the issues and believe the remaining issues
only occur on Windows. I have enabled the test on all platforms other than
windows here.

[chromium-reviews, 2015-03-24 18:33:34]

Thanks for the heads up, will keep an eye out for issues.

On Tue, Mar 24, 2015 at 2:20 PM, <dyen@chromium.org> wrote:

> On 2015/03/24 18:16:07, sullivan wrote:
>
>> On 2015/03/24 17:37:59, nednguyen wrote:
>> > On 2015/03/24 17:30:56, David Yen wrote:
>> > > On 2015/03/24 17:30:18, David Yen wrote:
>> > >
>> > > Let's try enabling this and keep a close watch.
>> >
>> > Can you run a tryjob to make sure before we land this? :-)
>>
>
>  +1 for tryjob and also mailing mailto:perf-sheriffs@chromium.org to
>> notify.
>>
>
> Added perf sheriffs to CC list, triggered try jobs.
>
> Perf Sheriffs, I am enabling a perf test that has been known to be flaky
> in the
> past. We have sorted out most of the issues and believe the remaining
> issues
> only occur on Windows. I have enabled the test on all platforms other than
> windows here.
>
> https://codereview.chromium.org/1029423002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nednguyen, 2015-03-25 16:19:26]

On 2015/03/24 18:33:34, chromium-reviews wrote:
> Thanks for the heads up, will keep an eye out for issues.
> 
> On Tue, Mar 24, 2015 at 2:20 PM, <mailto:dyen@chromium.org> wrote:
> 
> > On 2015/03/24 18:16:07, sullivan wrote:
> >
> >> On 2015/03/24 17:37:59, nednguyen wrote:
> >> > On 2015/03/24 17:30:56, David Yen wrote:
> >> > > On 2015/03/24 17:30:18, David Yen wrote:
> >> > >
> >> > > Let's try enabling this and keep a close watch.
> >> >
> >> > Can you run a tryjob to make sure before we land this? :-)
> >>
> >
> >  +1 for tryjob and also mailing mailto:perf-sheriffs@chromium.org to
> >> notify.
> >>
> >
> > Added perf sheriffs to CC list, triggered try jobs.
> >
> > Perf Sheriffs, I am enabling a perf test that has been known to be flaky
> > in the
> > past. We have sorted out most of the issues and believe the remaining
> > issues
> > only occur on Windows. I have enabled the test on all platforms other than
> > windows here.
> >
> > https://codereview.chromium.org/1029423002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

lgtm if the try jobs pass.

[David Yen, 2015-03-25 21:25:21]

The CQ bit was checked by dyen@chromium.org

[commit-bot: I haz the power, 2015-03-25 21:25:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029423002/1

[commit-bot: I haz the power, 2015-03-26 00:28:49]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-26 00:29:44]

Patchset 1 (id:??) landed as
https://crrev.com/95325bb92cdce4b3c4fd93ae3509e72f89536c9c
Cr-Commit-Position: refs/heads/master@{#322273}

[Rick Byers, 2015-03-27 01:21:33]

On 2015/03/26 00:29:44, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/95325bb92cdce4b3c4fd93ae3509e72f89536c9c
> Cr-Commit-Position: refs/heads/master@{#322273}

Note that I'm seeing most bots failing gpu_times ever since this landed (Eg.
http://goo.gl/uLzMVe).  I missed this earlier because we had a bunch of
persistent redness today caused by multiple bad V8 rolls and didn't notice this
crept in as well.

Failure is just on cuteoverload.com with an error like the below.  Preparing a
revert now to try to get the bots green.

[ RUN      ] http://cuteoverload.com
INFO:root:Requested remote debugging port: 42676
Traceback (most recent call last):
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/user_story/user_story_runner.py",
line 88, in _RunUserStoryAndProcessErrorIfNeeded
    state.RunUserStory(results)
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/page/shared_page_state.py",
line 254, in RunUserStory
    self._test.RunPage(self._current_page, self._current_tab, results)
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/page/page_test.py",
line 219, in RunPage
    self.ValidateAndMeasurePage(page, tab, results)
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/web_perf/timeline_based_measurement.py",
line 249, in ValidateAndMeasurePage
    self._measurement.Measure(tracing_controller, results)
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/web_perf/timeline_based_measurement.py",
line 218, in Measure
    model = model_module.TimelineModel(trace_result)
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/timeline/model.py",
line 73, in __init__
    self.ImportTraces(trace_data, shift_world_to_zero=shift_world_to_zero)
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/timeline/model.py",
line 151, in ImportTraces
    self.FinalizeImport(shift_world_to_zero, importers)
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/timeline/model.py",
line 163, in FinalizeImport
    importer.FinalizeImport()
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/timeline/tab_id_importer.py",
line 31, in FinalizeImport
    self._CreateTabIdsToThreadsMap()
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/timeline/tab_id_importer.py",
line 50, in _CreateTabIdsToThreadsMap
    timeline_markers = self._model.FindTimelineMarkers(tab_id)
  File
"/b/build/slave/Linux_Perf__2_/build/src/tools/perf/../telemetry/telemetry/timeline/model.py",
line 238, in FindTimelineMarkers
    raise MarkerMismatchError()
MarkerMismatchError: Number or order of timeline markers does not match provided
labels

[  FAILED  ] http://cuteoverload.com (26636 ms)

[Rick Byers, 2015-03-27 01:23:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1039083002/ by rbyers@chromium.org.

The reason for reverting is: 
I'm seeing most perf bots failing gpu_times ever since this landed (Eg.
http://goo.gl/uLzMVe).

I missed this earlier because we had a bunch of persistent redness today caused
by multiple bad V8 rolls and didn't notice this crept in as well.

Failure is just on cuteoverload.com with this error: 
MarkerMismatchError: Number or order of timeline markers does not match provided
labels
.