Issue 10294: * Added d8 flag "--" (alias "--js-arguments")

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10294: * Added d8 flag "--" (alias "--js-arguments") (Closed)

Created:
12 years, 1 month ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Arguments on the command line are made available as a global "arguments" array. Fix for non-empty assertion in debug mode (string representation of empty arguments is a single space, not an empty string).

Patch Set 1 #

Patch Set 2 : Changed flags.cc to use StringStream internally #

Patch Set 3 : Addressed review comments #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -49 lines)			Patch
M	src/d8.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/disassembler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/flag-definitions.h	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	src/flags.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/flags.cc	View	1 2	12 chunks	+109 lines, -39 lines	0 comments	Download
M	src/log.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/serialize.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/string-stream.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/string-stream.cc	View	2	2 chunks	+9 lines, -2 lines	0 comments	Download
M	test/cctest/test-flags.cc	View		1 chunk	+64 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Re-review. Only change since last time is that ToString(Flag*) never returns an empty string. It ...

12 years, 1 month ago (2008-11-11 09:59:10 UTC) #1

Christian Plesner Hansen

12 years, 1 month ago (2008-11-11 14:02:27 UTC) #2

Lgtm

http://codereview.chromium.org/10294/diff/7/11
File src/flags.cc (right):

http://codereview.chromium.org/10294/diff/7/11#newcode201
Line 201: if (str) {
How about

  buffer.Add("%s", str ? str : "NULL");

http://codereview.chromium.org/10294/diff/7/15
File src/string-stream.cc (right):

http://codereview.chromium.org/10294/diff/7/15#newcode146
Line 146: EmbeddedVector<char, 24> formatted;
Is 24 enough in all cases?

Expand Messages | Collapse Messages