Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1029383002: [turbofan] Address minor TODOs in instruction selector. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Address minor TODOs in instruction selector. R=dcarney@chromium.org BUG= Committed: https://crrev.com/125d31ecfd0bbcd61eb640f6eedfc5d90603ce45 Cr-Commit-Position: refs/heads/master@{#27410}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/compiler/ia32/instruction-selector-ia32.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 9 months ago (2015-03-24 13:22:10 UTC) #1
dcarney
lgtm
5 years, 9 months ago (2015-03-24 13:33:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029383002/1
5 years, 9 months ago (2015-03-24 13:35:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 14:09:37 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 14:09:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/125d31ecfd0bbcd61eb640f6eedfc5d90603ce45
Cr-Commit-Position: refs/heads/master@{#27410}

Powered by Google App Engine
This is Rietveld 408576698