Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1029353002: Revert of Revert of Unflake V8 sampling profiler tests. (Closed)

Created:
5 years, 9 months ago by alph
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1017183004/) Reason for revert: Suspecting goma flake. Relanding. Original issue's description: > Revert of Unflake V8 sampling profiler tests. (patchset #1 id:1 of https://codereview.chromium.org/1032633002/) > > Reason for revert: > Broke compilation on Mac Builder: > https://build.chromium.org/p/chromium.mac/builders/Mac%20Builder/builds/19512/steps/compile/logs/stdio > > when compiling content/renderer/devtools/v8_sampling_profiler_browsertest.cc > > Original issue's description: > > Unflake V8 sampling profiler tests. > > > > BUG=406277 > > > > Committed: https://crrev.com/d6493ce2a4ed6f346a31597ac27748a3429a1d95 > > Cr-Commit-Position: refs/heads/master@{#321970} > > TBR=yurys@chromium.org,alph@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=406277 > > Committed: https://crrev.com/3703085199a63732add21d955c6280765e3c480e > Cr-Commit-Position: refs/heads/master@{#321975} TBR=yurys@chromium.org,pneubeck@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=406277 Committed: https://crrev.com/84fec4265a487f13b3edac5770b4ca02df95466a Cr-Commit-Position: refs/heads/master@{#321977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M content/renderer/devtools/v8_sampling_profiler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/devtools/v8_sampling_profiler.cc View 6 chunks +19 lines, -5 lines 0 comments Download
M content/renderer/devtools/v8_sampling_profiler_browsertest.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
Created Revert of Revert of Unflake V8 sampling profiler tests.
5 years, 9 months ago (2015-03-24 12:14:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029353002/1
5 years, 9 months ago (2015-03-24 12:14:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 12:15:21 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 12:16:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84fec4265a487f13b3edac5770b4ca02df95466a
Cr-Commit-Position: refs/heads/master@{#321977}

Powered by Google App Engine
This is Rietveld 408576698