Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1029323003: Track how many pages trigger fallback strategies in GC (Closed)

Created:
5 years, 9 months ago by Erik Corry Chromium.org
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Track how many pages trigger fallback strategies in GC R=hpayer@chromium.org BUG= Committed: https://crrev.com/bb880058f6499510cff12d98dc7d524d35d769cb Cr-Commit-Position: refs/heads/master@{#27421}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename stack to deque #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -22 lines) Patch
M include/v8.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/heap/mark-compact.h View 2 chunks +1 line, -21 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 chunks +25 lines, -0 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Erik Corry Chromium.org
5 years, 9 months ago (2015-03-24 11:27:41 UTC) #1
Hannes Payer (out of office)
lgtm, one nit https://codereview.chromium.org/1029323003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1029323003/diff/1/include/v8.h#newcode5074 include/v8.h:5074: kMarkStackOverflow = 3, Can we call ...
5 years, 9 months ago (2015-03-24 15:26:06 UTC) #2
Erik Corry Chromium.org
https://codereview.chromium.org/1029323003/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1029323003/diff/1/include/v8.h#newcode5074 include/v8.h:5074: kMarkStackOverflow = 3, On 2015/03/24 15:26:06, Hannes Payer wrote: ...
5 years, 9 months ago (2015-03-24 15:36:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029323003/20001
5 years, 9 months ago (2015-03-24 15:37:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 16:17:47 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bb880058f6499510cff12d98dc7d524d35d769cb Cr-Commit-Position: refs/heads/master@{#27421}
5 years, 9 months ago (2015-03-24 16:18:05 UTC) #8
Michael Achenbach
5 years, 9 months ago (2015-03-24 21:57:26 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1000523003/ by machenbach@chromium.org.

The reason for reverting is: This seems to cause lots of crashes in layout tests
debug:
../../third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp(67) : void
blink::useCounterCallback(v8::Isolate *, v8::Isolate::UseCounte

http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg....

Powered by Google App Engine
This is Rietveld 408576698