Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1029263008: Revert of Re-enable ChannelMojo (Closed)

Created:
5 years, 9 months ago by tkent
Modified:
5 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable ChannelMojo (patchset #1 id:1 of https://codereview.chromium.org/1021393002/) Reason for revert: speculative revert for "Too many open files" on various Mac bots. e.g. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/17511/steps/webkit_tests/logs/stdio Original issue's description: > Re-enable ChannelMojo > > It was disabled due to crbug.com/466814 that is now fixed. > It's time to turn it on again. > > R=viettrungluu@chromium.org > BUG=466814, 377980 > > Committed: https://crrev.com/c99c93842fa50f85888d069f0be962462f92a643 > Cr-Commit-Position: refs/heads/master@{#322092} TBR=viettrungluu@chromium.org,morrita@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=466814, 377980 Committed: https://crrev.com/9e4596122cda5dbc959895b53679e14df45658b5 Cr-Commit-Position: refs/heads/master@{#322113}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Created Revert of Re-enable ChannelMojo
5 years, 9 months ago (2015-03-25 04:39:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029263008/1
5 years, 9 months ago (2015-03-25 04:40:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 04:41:31 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e4596122cda5dbc959895b53679e14df45658b5 Cr-Commit-Position: refs/heads/master@{#322113}
5 years, 9 months ago (2015-03-25 04:42:06 UTC) #4
tkent
5 years, 9 months ago (2015-03-25 05:58:53 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1031083002/ by tkent@chromium.org.

The reason for reverting is: It seems it was not guilty.
According to Android Tests (dbg) bot, revering #322094 was enough.
.

Powered by Google App Engine
This is Rietveld 408576698