Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1029263006: Roll DomDistillerJS (Closed)

Created:
5 years, 9 months ago by mdjones
Modified:
5 years, 9 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll DOM Distiller JavaScript distribution package Diff since last roll: https://github.com/chromium/dom-distiller/compare/8c015c13ad...cc268ee730 Picked up changes: cc268ee Revert "Treat images as another type of embed" a7949c7 implement extraction of page parameters from potential pagination URLs 47c825f Add target "ant runtest" to run tests without recompiling 7a29e21 Fixes a crash when window.performance is not available. b7b4d4a Fixing python header. 1c2dd98 Revert "Disable flaky page link tests" 2a64c8d Use a much simpler baseUrl heuristics 3e49cf2 Fix flakiness due to a bug in createAnchorWithBase() d69f15d Allow multiple instances of "ant test" running d9fb022 Put steps in continuous integration into a bash script 94320fe Unify the style in Ant target descriptions 4adbcfa Don't let base tag change original_url a3a07ce Disable flaky page link tests 0b8c2e7 Treat images as another type of embed d49edaf Add pagenum difference in the next page heuristics abee435 Do not sum up scores of next page links with the same URL 0955aa3 Use numbers as a fast filter in next page detection ff4bc3d Fix relative link resolution with base tag 875b0ff Use URL prefix as a fast filter in next page detection 7b12bc7 Resolve links in a new HTML document with a base tag ab96c56 Add timing info for pagination 2812744 Add support for wrapping the standalone JavaScript. 7bd24c4 Groundwork for retaining popular embeds in results 4b3cdb9 Add instructions for using `git cl format`. 94c8270 Add project introduction in README.md 86983de Add support for running jstests on Mac OS X and add documentation. f33d992 Add JS tests to package and suppress log output. 1a42d14 Make the "test" target not depend on "package" eabc11d Add data tables to the WebDocument 669d605 Revert "Disable some tests in PagingLinksFinderTest" 2874c7b Fix the page URL in PagingLinksFinderTest ddc30e2 Fix next-page tests for new mocking mechanism BUG=431067, 450813, 455503, 464143 Committed: https://crrev.com/c430d4b17cbb9b2cc055777c0124cdce745479da Cr-Commit-Position: refs/heads/master@{#322180}

Patch Set 1 #

Patch Set 2 : Updated roll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/dom_distiller_js/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
mdjones
Distiller roll.
5 years, 9 months ago (2015-03-24 22:52:41 UTC) #2
nyquist
I don't think you are using the right roll-script. There should be no files in ...
5 years, 9 months ago (2015-03-24 22:53:29 UTC) #3
nyquist
lgtm
5 years, 9 months ago (2015-03-24 23:12:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029263006/10001
5 years, 9 months ago (2015-03-24 23:13:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/46824)
5 years, 9 months ago (2015-03-25 04:08:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029263006/10001
5 years, 9 months ago (2015-03-25 15:59:47 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:10001)
5 years, 9 months ago (2015-03-25 17:07:21 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 17:07:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c430d4b17cbb9b2cc055777c0124cdce745479da
Cr-Commit-Position: refs/heads/master@{#322180}

Powered by Google App Engine
This is Rietveld 408576698