Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1029263004: SkPDF: clean up extra references (Closed)

Created:
5 years, 9 months ago by hal.canary
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: clean up extra references This cleans up code left behind from http://crrev.com/870333002 Committed: https://skia.googlesource.com/skia/+/547019e1a671b1b30746e69b9647b201500e1504

Patch Set 1 : 2015-03-23 (Monday) 20:01:49 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M src/pdf/SkPDFDevice.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFResourceDict.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/pdf/SkPDFResourceDict.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/pdf/SkPDFShader.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/pdf/SkPDFShader.cpp View 7 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029263004/20001
5 years, 9 months ago (2015-03-24 00:02:38 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-24 00:02:39 UTC) #4
hal.canary
ptal
5 years, 9 months ago (2015-03-24 00:02:51 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-24 06:02:41 UTC) #8
mtklein
lgtm
5 years, 9 months ago (2015-03-24 15:12:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029263004/20001
5 years, 9 months ago (2015-03-24 15:12:44 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 15:13:00 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/547019e1a671b1b30746e69b9647b201500e1504

Powered by Google App Engine
This is Rietveld 408576698