Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1029183002: Use a less compiler-specific way for preventing inlining / tail-call optimization. (Closed)

Created:
5 years, 9 months ago by Nico
Modified:
5 years, 1 month ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, erikwright+watch_chromium.org, Mike Wittman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a less compiler-specific way for preventing inlining / tail-call optimization. The current method is MSVS-specific. With just NOINLINE, clang still does a tail call, which also prevents a stack frame, so also add some dummy machinery that makes the tail-call optimization impossible. BUG=469813 Committed: https://crrev.com/916eb91eabfed357395b5f0aa26490a0469ce081 Cr-Commit-Position: refs/heads/master@{#321895}

Patch Set 1 #

Patch Set 2 : nicer #

Patch Set 3 : gcccccccc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M base/profiler/stack_sampling_profiler_unittest.cc View 1 2 1 chunk +5 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Nico
5 years, 9 months ago (2015-03-23 20:44:01 UTC) #2
Reid Kleckner
lgtm
5 years, 9 months ago (2015-03-23 21:11:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029183002/1
5 years, 9 months ago (2015-03-23 21:24:40 UTC) #5
Nico
i tweaked this to be slightly less gross and more robust, based on majnemer's suggestion
5 years, 9 months ago (2015-03-23 22:15:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029183002/20001
5 years, 9 months ago (2015-03-23 22:16:06 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/4568)
5 years, 9 months ago (2015-03-23 22:30:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029183002/40001
5 years, 9 months ago (2015-03-23 22:44:43 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-23 23:23:07 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/916eb91eabfed357395b5f0aa26490a0469ce081 Cr-Commit-Position: refs/heads/master@{#321895}
5 years, 9 months ago (2015-03-23 23:23:54 UTC) #17
Reid Kleckner
5 years, 1 month ago (2015-11-05 00:07:29 UTC) #18
Message was sent while issue was closed.
Akira is adding a "disable_tail_calls" attribute to clang that we could use
instead. It's not portable across compilers, though, and these volatile stores
are.

Powered by Google App Engine
This is Rietveld 408576698