tests/PMFloatTest.cpp - Issue 1029163002: Replace _mm_cvtps_epi32(x) with _mm_cvttps_epi32(_mm_add_ps(0.5f), x).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PMFloatTest.cpp

Issue 1029163002: Replace _mm_cvtps_epi32(x) with _mm_cvttps_epi32(_mm_add_ps(0.5f), x). (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: tweak test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/PMFloatTest.cpp

diff --git a/tests/PMFloatTest.cpp b/tests/PMFloatTest.cpp

index c3d5e48b4dd6e5eec107d208947d442043b11e45..5b53fc659f6f937958a066b3d31b91ea3c7631e2 100644

--- a/tests/PMFloatTest.cpp

+++ b/tests/PMFloatTest.cpp

@@ -11,8 +11,8 @@ DEF_TEST(SkPMFloat, r) {

REPORTER_ASSERT(r, SkScalarNearlyEqual( 51.0f, pmf.b()));

REPORTER_ASSERT(r, c == pmf.get());

- // Test rounding. (Don't bother testing .5... we don't care which way it goes.)

- pmf = SkPMFloat(254.6f, 204.3f, 153.1f, 50.8f);

+ // Test rounding.

+ pmf = SkPMFloat(254.5f, 203.5f, 153.1f, 50.8f);

REPORTER_ASSERT(r, c == pmf.get());

// Test clamping.

« no previous file with comments | « src/opts/SkPMFloat_SSSE3.h ('k') | tests/Sk4xTest.cpp » ('j') | no next file with comments »