[es5] call ToString() on argument in String.prototype.concat() fast case

[es5] call ToString() on argument in String.prototype.concat() fast case

15.5.4.6 5.b requires each part to be converted using ToString(). This also needs to occur in the single argument fast-case.

BUG=v8:3981
R=arv@chromium.org
LOG=N

Committed: https://crrev.com/24a9b8815ee1f6c366401d56f01ef4befd69eb36
Cr-Commit-Position: refs/heads/master@{#27372}

[caitp (gmail), 2015-03-23 14:20:36]

PTAL

[arv (Not doing code reviews), 2015-03-23 14:34:45]

LGTM with nit.

Can you expand the CL description a bit?

https://codereview.chromium.org/1029103002/diff/1/test/mjsunit/string-concat.js
File test/mjsunit/string-concat.js (right):

https://codereview.chromium.org/1029103002/diff/1/test/mjsunit/string-concat....
test/mjsunit/string-concat.js:1: // Copyright 2014 the V8 project authors. All
rights reserved.
15

https://codereview.chromium.org/1029103002/diff/1/test/mjsunit/string-concat....
test/mjsunit/string-concat.js:5: function Stringified(toString, valueOf) {
The test never passes 2 args

[caitp (gmail), 2015-03-23 14:43:37]

On 2015/03/23 14:34:45, arv wrote:
> LGTM with nit.
> 
> Can you expand the CL description a bit?
> 
>
https://codereview.chromium.org/1029103002/diff/1/test/mjsunit/string-concat.js
> File test/mjsunit/string-concat.js (right):
> 
>
https://codereview.chromium.org/1029103002/diff/1/test/mjsunit/string-concat....
> test/mjsunit/string-concat.js:1: // Copyright 2014 the V8 project authors. All
> rights reserved.
> 15
> 
>
https://codereview.chromium.org/1029103002/diff/1/test/mjsunit/string-concat....
> test/mjsunit/string-concat.js:5: function Stringified(toString, valueOf) {
> The test never passes 2 args

Done

[caitp (gmail), 2015-03-23 14:48:03]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-03-23 14:48:04]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1029103002/#ps20001
(title: "Fix nits")

[commit-bot: I haz the power, 2015-03-23 14:48:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1029103002/20001

[commit-bot: I haz the power, 2015-03-23 15:07:47]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-23 15:07:52]

Patchset 2 (id:??) landed as
https://crrev.com/24a9b8815ee1f6c366401d56f01ef4befd69eb36
Cr-Commit-Position: refs/heads/master@{#27372}