Source/bindings/tests/results/core/V8TestObject.cpp - Issue 1029093003: [WIP] IDL: Add limited serializer support and use for RTCIceCandidate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 1029093003: [WIP] IDL: Add limited serializer support and use for RTCIceCandidate (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use V8ObjectBuilder in modules/crypto Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/V8ObjectBuilder.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterface2.cpp ('k') | Source/modules/crypto/CryptoKey.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestObject.cpp

diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp

index 76e7009faf351816ef1a3bfc8c301a0d2815862a..8ce88554e21054492e581b3060db3be04f1bf527 100644

--- a/Source/bindings/tests/results/core/V8TestObject.cpp

+++ b/Source/bindings/tests/results/core/V8TestObject.cpp

@@ -11886,7 +11886,7 @@ static void setMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

static void toStringMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

{

TestObject* impl = V8TestObject::toImpl(info.Holder());

- v8SetReturnValueString(info, impl->toString(), info.GetIsolate());

+ v8SetReturnValueString(info, impl->stringifierAttribute(), info.GetIsolate());

}

static void toStringMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& info)

« Source/bindings/core/v8/V8ObjectBuilder.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterface2.cpp ('k') | Source/modules/crypto/CryptoKey.cpp » ('j') | no next file with comments »