Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: Source/bindings/scripts/idl_definitions.py

Issue 1029093003: [WIP] IDL: Add limited serializer support and use for RTCIceCandidate (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use V8ObjectBuilder in modules/crypto Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/idl_definitions.py
diff --git a/Source/bindings/scripts/idl_definitions.py b/Source/bindings/scripts/idl_definitions.py
index 693e1114beb288fa294f4ab36ca6aef9f97bf26b..b7188568d72c6adbae83a25e2881bea2ad104ba2 100644
--- a/Source/bindings/scripts/idl_definitions.py
+++ b/Source/bindings/scripts/idl_definitions.py
@@ -47,6 +47,7 @@ IdlDefinitions
IdlLiteral
IdlOperation < TypedObject
IdlArgument < TypedObject
+ IdlSerializer
IdlStringifier
IdlIterable < IdlIterableOrMaplikeOrSetlike
IdlMaplike < IdlIterableOrMaplikeOrSetlike
@@ -265,6 +266,7 @@ class IdlInterface(object):
self.extended_attributes = {}
self.operations = []
self.parent = None
+ self.serializer = None
self.stringifier = None
self.iterable = None
self.maplike = None
@@ -299,6 +301,9 @@ class IdlInterface(object):
self.operations.append(IdlOperation(idl_name, child))
elif child_class == 'Inherit':
self.parent = child.GetName()
+ elif child_class == 'Serializer':
+ self.serializer = IdlSerializer(idl_name, child)
+ self.process_serializer()
elif child_class == 'Stringifier':
self.stringifier = IdlStringifier(idl_name, child)
self.process_stringifier()
@@ -333,6 +338,12 @@ class IdlInterface(object):
elif self.setlike:
self.setlike.accept(visitor)
+ def process_serializer(self):
+ """Add the serializer's named operation child, if it has one, as a regular
+ operation of this interface."""
+ if self.serializer.operation:
+ self.operations.append(self.serializer.operation)
+
def process_stringifier(self):
"""Add the stringifier's attribute or named operation child, if it has
one, as a regular attribute/operation of this interface."""
@@ -506,6 +517,9 @@ def default_node_to_idl_literal(node):
################################################################################
class IdlOperation(TypedObject):
+ def __str__(self):
+ return "%s %s(%s)" % (self.idl_type, self.name, ", ".join(str(a) for a in self.arguments))
+
def __init__(self, idl_name, node=None):
self.arguments = []
self.extended_attributes = {}
@@ -581,6 +595,9 @@ class IdlOperation(TypedObject):
################################################################################
class IdlArgument(TypedObject):
+ def __str__(self):
+ return "%s %s" % (self.idl_type, self.name)
+
def __init__(self, idl_name, node=None):
self.extended_attributes = {}
self.idl_type = None
@@ -636,6 +653,43 @@ def arguments_node_to_arguments(idl_name, node):
################################################################################
+# Serializers
+################################################################################
+
+class IdlSerializer(object):
+ def __init__(self, idl_name, node):
+ self.attribute_name = node.GetProperty('ATTRIBUTE')
+ self.attribute_names = None
+ self.operation = None
+ self.extended_attributes = {}
+ self.is_attribute = False
+ self.is_getter = False
+ self.is_inherit = False
+ self.is_list = False
+ self.is_map = False
+ self.idl_name = idl_name
+
+ for child in node.GetChildren():
+ child_class = child.GetClass()
+ if child_class == 'Operation':
+ self.operation = IdlOperation(idl_name, child)
+ elif child_class == 'List':
+ self.is_list = True
+ self.is_getter = bool(child.GetProperty('GETTER'))
+ self.attributes = child.GetProperty('ATTRIBUTES')
+ elif child_class == 'Map':
+ self.is_map = True
+ self.is_attribute = bool(child.GetProperty('ATTRIBUTE'))
+ self.is_getter = bool(child.GetProperty('GETTER'))
+ self.is_inherit = bool(child.GetProperty('INHERIT'))
+ self.attributes = child.GetProperty('ATTRIBUTES')
+ elif child_class == 'ExtAttributes':
+ self.extended_attributes = ext_attributes_node_to_extended_attributes(idl_name, child)
+ else:
+ raise ValueError('Unrecognized node class: %s' % child_class)
+
+
+################################################################################
# Stringifiers
################################################################################

Powered by Google App Engine
This is Rietveld 408576698