Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1029063002: [V8] Removed debug-sourceinfo.js with CRLF line endings (Closed)

Created:
5 years, 9 months ago by kozy
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[V8] Removed debug-sourceinfo.js with CRLF line endings We can't simple delete and add one file in one CL. This is necessary for replacing this test with version with LF line endings. R=yangguo@chromium.org Committed: https://crrev.com/ec9f0a5307008f317bde628909cdc1256389fb09 Cr-Commit-Position: refs/heads/master@{#27368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -352 lines) Patch
D test/mjsunit/debug-sourceinfo.js View 1 chunk +0 lines, -352 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kozy
Yang, please take a look. For landing https://codereview.chromium.org/1022333004/ because our tools replace line endings after ...
5 years, 9 months ago (2015-03-23 12:30:11 UTC) #1
kozy
Yang, ptal. More details in https://codereview.chromium.org/1029063002/
5 years, 9 months ago (2015-03-23 12:30:32 UTC) #2
Yang
On 2015/03/23 12:30:32, kozyatinskiy wrote: > Yang, ptal. More details in https://codereview.chromium.org/1029063002/ lgtm.
5 years, 9 months ago (2015-03-23 14:10:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029063002/1
5 years, 9 months ago (2015-03-23 14:12:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 14:31:38 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 14:31:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec9f0a5307008f317bde628909cdc1256389fb09
Cr-Commit-Position: refs/heads/master@{#27368}

Powered by Google App Engine
This is Rietveld 408576698