chrome/browser/resources/chromeos/login/screen_gaia_signin.html - Issue 1029053002: Back button for the WebView-based sign-in flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/screen_gaia_signin.html

Issue 1029053002: Back button for the WebView-based sign-in flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Prevent double click. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/chromeos/login/screen_gaia_signin.html

diff --git a/chrome/browser/resources/chromeos/login/screen_gaia_signin.html b/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

index 65450eb24f3d8bc608e02b5bdd483f04cf5e72e7..43cf5f20eec3aa8195db052de366d726fa48b1a0 100644

--- a/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

+++ b/chrome/browser/resources/chromeos/login/screen_gaia_signin.html

@@ -36,6 +36,8 @@

</div>

+ <button id="back-button-item" class="custom-appearance" hidden

+ i18n-values="aria-label:backButton" tabindex="0"></button>

Nikita (slow) 2015/03/24 11:56:03 nit: just 4 spaces indent for attributes

<button id="close-button-item" class="custom-appearance" hidden

i18n-values="aria-label:closeButton" tabindex="0"></button>

Nikita (slow) 2015/03/24 11:56:03 nit: same here

</div>