Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1029053002: Back button for the WebView-based sign-in flow. (Closed)

Created:
5 years, 9 months ago by Ivan Podogov
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow), oshima
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Back button for the WebView-based sign-in flow. The button state is being updated in the backButton event. It remains hidden until the first such event and after each click, so the <webview> can always control if the button is needed at all. BUG=462660 Committed: https://crrev.com/46217629a68853bc7d3a21b65180fe6c71d39f5f Cr-Commit-Position: refs/heads/master@{#321990}

Patch Set 1 #

Patch Set 2 : Support webview's backButton message. #

Patch Set 3 : Prevent double click. #

Total comments: 2

Patch Set 4 : Nit. #

Messages

Total messages: 9 (3 generated)
Ivan Podogov
PTAL
5 years, 9 months ago (2015-03-23 14:37:33 UTC) #2
oshima
c/a/theme lgtm
5 years, 9 months ago (2015-03-23 21:01:00 UTC) #3
Nikita (slow)
lgtm please update CL description https://codereview.chromium.org/1029053002/diff/40001/chrome/browser/resources/chromeos/login/screen_gaia_signin.html File chrome/browser/resources/chromeos/login/screen_gaia_signin.html (right): https://codereview.chromium.org/1029053002/diff/40001/chrome/browser/resources/chromeos/login/screen_gaia_signin.html#newcode40 chrome/browser/resources/chromeos/login/screen_gaia_signin.html:40: i18n-values="aria-label:backButton" tabindex="0"></button> nit: just ...
5 years, 9 months ago (2015-03-24 11:56:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029053002/60001
5 years, 9 months ago (2015-03-24 12:50:07 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-24 13:30:13 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 13:31:01 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/46217629a68853bc7d3a21b65180fe6c71d39f5f
Cr-Commit-Position: refs/heads/master@{#321990}

Powered by Google App Engine
This is Rietveld 408576698