Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1029033003: [DevTools] Only create DevToolsAgent for local main frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed review comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index d411147589e6a4a92c1f6315ee13c27ff4c00e2d..5872c9af4e4436f9af9e34e0acdde8474500dfb7 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -3221,8 +3221,10 @@ void RenderFrameImpl::didFinishResourceLoad(blink::WebLocalFrame* frame,
return;
// Do not show error page when DevTools is attached.
- if (render_view_->devtools_agent_->IsAttached())
+ if (render_view_->devtools_agent_ &&
+ render_view_->devtools_agent_->IsAttached()) {
return;
+ }
// Display error page, if appropriate.
std::string error_domain = "http";
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698