Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1029033003: [DevTools] Only create DevToolsAgent for local main frame. (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Only create DevToolsAgent for local main frame. This is already the case on the blink side. In future, DevToolsAgent will move to RenderFrame and will be created for every local frame root. BUG=451004 Committed: https://crrev.com/d59a26aaecd1e57074b7ca0066832f1d35b748de Cr-Commit-Position: refs/heads/master@{#321776}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dgozman
Take a look please.
5 years, 9 months ago (2015-03-23 12:00:19 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1029033003/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/1029033003/diff/1/content/renderer/render_view_impl.cc#newcode782 content/renderer/render_view_impl.cc:782: if (webview()->devToolsAgent()) { Place to under the if ...
5 years, 9 months ago (2015-03-23 12:49:44 UTC) #3
dgozman
https://codereview.chromium.org/1029033003/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/1029033003/diff/1/content/renderer/render_view_impl.cc#newcode782 content/renderer/render_view_impl.cc:782: if (webview()->devToolsAgent()) { On 2015/03/23 12:49:44, pfeldman wrote: > ...
5 years, 9 months ago (2015-03-23 13:28:26 UTC) #4
nasko
LGTM
5 years, 9 months ago (2015-03-23 14:00:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1029033003/20001
5 years, 9 months ago (2015-03-23 14:05:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 15:02:02 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 15:03:05 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d59a26aaecd1e57074b7ca0066832f1d35b748de
Cr-Commit-Position: refs/heads/master@{#321776}

Powered by Google App Engine
This is Rietveld 408576698