Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1028983002: X87: [es6] Throw TypeError for computed static prototype property name (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [es6] Throw TypeError for computed static prototype property name port 8d946b9c3f6ea42dd5232c0529be4d47798b06aa (r27106). original commit message: [es6] Throw TypeError for computed static prototype property name The prototype of a class constructor function is read only. When we set computed property names we were ignoring this and we were overriding the property. Since the prototype is the only possible own read only property on the constructor function object we special case this so we do not have to check this for every property in the class literal. BUG= Committed: https://crrev.com/113037d9f32d70602ab79a5d1b75c949a89ac49d Cr-Commit-Position: refs/heads/master@{#27356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/x87/full-codegen-x87.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-23 08:15:13 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-23 08:19:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028983002/1
5 years, 9 months ago (2015-03-23 08:20:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 08:50:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 08:50:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/113037d9f32d70602ab79a5d1b75c949a89ac49d
Cr-Commit-Position: refs/heads/master@{#27356}

Powered by Google App Engine
This is Rietveld 408576698