Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 1028923002: Make some changes to the QuicInMemory server to clarify the interface. (Closed)

Created:
5 years, 9 months ago by Ryan Hamilton
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make some changes to the QuicInMemory server to clarify the interface. Specifically that the cache is indexed by host and path, not by method nor scheme, nor full URL, nor request headers, etc. In preparation for making the chrome version more similar. Merge internal change: 89092881 Committed: https://crrev.com/aa7859a1d935be0283912ab47815a800116a1138 Cr-Commit-Position: refs/heads/master@{#321883}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -184 lines) Patch
M net/quic/quic_end_to_end_unittest.cc View 1 5 chunks +9 lines, -19 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 6 chunks +11 lines, -17 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 3 chunks +19 lines, -11 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 5 chunks +43 lines, -65 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache_test.cc View 1 2 chunks +23 lines, -64 lines 0 comments Download
M net/tools/quic/quic_spdy_server_stream.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 2 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ryan Hamilton
Hi Raman, I merged this myself. PTAL.
5 years, 9 months ago (2015-03-23 02:10:03 UTC) #2
ramant (doing other things)
lgtm
5 years, 9 months ago (2015-03-23 18:03:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028923002/1
5 years, 9 months ago (2015-03-23 20:29:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51404)
5 years, 9 months ago (2015-03-23 20:37:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028923002/20001
5 years, 9 months ago (2015-03-23 22:15:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 22:50:18 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 22:51:35 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa7859a1d935be0283912ab47815a800116a1138
Cr-Commit-Position: refs/heads/master@{#321883}

Powered by Google App Engine
This is Rietveld 408576698