Source/core/streams/ReadableStream.cpp - Issue 1028913002: ReadableStream.cancel's parameter should be optional.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/streams/ReadableStream.cpp

Issue 1028913002: ReadableStream.cancel's parameter should be optional. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/fetch/script-tests/stream-reader.js ('K') | « Source/core/streams/ReadableStream.h ('k') | Source/core/streams/ReadableStream.idl » ('j') | Source/modules/fetch/Body.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/streams/ReadableStream.cpp

diff --git a/Source/core/streams/ReadableStream.cpp b/Source/core/streams/ReadableStream.cpp

index 684e1358ad5e7b81c9271b425e3b255884e9ac8b..bce75ca5c44b58824eac4c0081d898ce0d90dbd5 100644

--- a/Source/core/streams/ReadableStream.cpp

+++ b/Source/core/streams/ReadableStream.cpp

@@ -93,6 +93,11 @@ void ReadableStream::readInternalPostAction()

callPullIfNeeded();

}

+ScriptPromise ReadableStream::cancel(ScriptState* scriptState)

+ return cancel(scriptState, ScriptValue(scriptState, v8::Undefined(scriptState->isolate())));

tyoshino (SeeGerritForStatus) 2015/03/23 03:57:21 use the same order as .h file

yhirano 2015/03/23 05:47:32 Done by modifying the header.

ScriptPromise ReadableStream::cancel(ScriptState* scriptState, ScriptValue reason)

{

if (m_reader)