ReadableStream.cancel's parameter should be optional.

ReadableStream.cancel's parameter should be optional.

BUG=469154
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192334

[yhirano, 2015-03-23 03:29:57]

yhirano@chromium.org changed reviewers:
+ horo@chromium.org, tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2015-03-23 03:57:21]

https://codereview.chromium.org/1028913002/diff/1/LayoutTests/http/tests/fetc...
File LayoutTests/http/tests/fetch/script-tests/stream-reader.js (right):

https://codereview.chromium.org/1028913002/diff/1/LayoutTests/http/tests/fetc...
LayoutTests/http/tests/fetch/script-tests/stream-reader.js:106: var read = 0;
remove

https://codereview.chromium.org/1028913002/diff/1/Source/core/streams/Readabl...
File Source/core/streams/ReadableStream.cpp (right):

https://codereview.chromium.org/1028913002/diff/1/Source/core/streams/Readabl...
Source/core/streams/ReadableStream.cpp:99: }
use the same order as .h file

https://codereview.chromium.org/1028913002/diff/1/Source/modules/fetch/Body.cpp
File Source/modules/fetch/Body.cpp (right):

https://codereview.chromium.org/1028913002/diff/1/Source/modules/fetch/Body.c...
Source/modules/fetch/Body.cpp:146: return ScriptPromise::cast(scriptState,
v8::Undefined(scriptState->isolate()));
which call terminates the fetch?

[yhirano, 2015-03-23 05:47:31]

yhirano@chromium.org changed reviewers:
- horo@chromium.org

[yhirano, 2015-03-23 05:47:32]

I changed the issue title and description. Now this CL makes parameters in
cancel operations optional.

I will fix the fetch termination problem later.

https://codereview.chromium.org/1028913002/diff/1/LayoutTests/http/tests/fetc...
File LayoutTests/http/tests/fetch/script-tests/stream-reader.js (right):

https://codereview.chromium.org/1028913002/diff/1/LayoutTests/http/tests/fetc...
LayoutTests/http/tests/fetch/script-tests/stream-reader.js:106: var read = 0;
On 2015/03/23 03:57:21, tyoshino wrote:
> remove

Reverted

https://codereview.chromium.org/1028913002/diff/1/Source/core/streams/Readabl...
File Source/core/streams/ReadableStream.cpp (right):

https://codereview.chromium.org/1028913002/diff/1/Source/core/streams/Readabl...
Source/core/streams/ReadableStream.cpp:99: }
On 2015/03/23 03:57:21, tyoshino wrote:
> use the same order as .h file

Done by modifying the header.

https://codereview.chromium.org/1028913002/diff/1/Source/modules/fetch/Body.cpp
File Source/modules/fetch/Body.cpp (right):

https://codereview.chromium.org/1028913002/diff/1/Source/modules/fetch/Body.c...
Source/modules/fetch/Body.cpp:146: return ScriptPromise::cast(scriptState,
v8::Undefined(scriptState->isolate()));
On 2015/03/23 03:57:21, tyoshino wrote:
> which call terminates the fetch?

You're right, and I found implementing the cancellation operation is a bit hard.
So I would fix the IDL related issue in this CL and fix the fetch termination
after that.

[tyoshino (SeeGerritForStatus), 2015-03-23 06:02:48]

lgtm

[yhirano, 2015-03-23 06:06:19]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2015-03-23 06:06:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1028913002/20001

[horo, 2015-03-23 06:41:11]

horo@chromium.org changed reviewers:
+ horo@chromium.org

[horo, 2015-03-23 06:41:11]

lgtm

[commit-bot: I haz the power, 2015-03-23 07:35:39]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192334