Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 1028893002: PagePopups should have the grab behavior same as <select> popup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 2b1704f20e6cf04234a310e52fd88995f7652ef5..de3434e8c13b873bff5a9912ee26fb16c25b7f92 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -2387,7 +2387,8 @@ void RenderWidgetHostViewAura::Shutdown() {
}
bool RenderWidgetHostViewAura::NeedsInputGrab() {
- return popup_type_ == blink::WebPopupTypeSelect;
+ return popup_type_ == blink::WebPopupTypeSelect
+ || popup_type_ == blink::WebPopupTypePage;
sadrul 2015/03/23 07:05:38 I think the style-guide suggests the || at the EOL
tkent 2015/03/23 07:08:40 You're right. 'git cl format' corrected this erro
}
bool RenderWidgetHostViewAura::NeedsMouseCapture() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698