Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1028863002: remove -Wno-header-guard workaround for old versions of NSS (Closed)

Created:
5 years, 9 months ago by Mostyn Bramley-Moore
Modified:
5 years, 9 months ago
Reviewers:
Nico, Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

remove -Wno-header-guard workaround for old versions of NSS I think it's safe to re-enable this warning now. The bug was fixed upstream in 3.15.1 and there have been several NSS upgrades since then. BUG=255201 Committed: https://crrev.com/86ebf48be903b226d068b08efa16fe3725babb8c Cr-Commit-Position: refs/heads/master@{#321711}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M build/linux/system.gyp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Mostyn Bramley-Moore
@Nico: PTAL.
5 years, 9 months ago (2015-03-21 22:55:47 UTC) #2
Nico
On 2015/03/21 22:55:47, Mostyn Bramley-Moore wrote: > @Nico: PTAL. Iirc think we pick up the ...
5 years, 9 months ago (2015-03-21 23:57:48 UTC) #3
Mostyn Bramley-Moore
On 2015/03/21 23:57:48, Nico wrote: > On 2015/03/21 22:55:47, Mostyn Bramley-Moore wrote: > > @Nico: ...
5 years, 9 months ago (2015-03-22 01:14:45 UTC) #4
Nico
On 2015/03/22 01:14:45, Mostyn Bramley-Moore wrote: > On 2015/03/21 23:57:48, Nico wrote: > > On ...
5 years, 9 months ago (2015-03-22 04:22:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028863002/1
5 years, 9 months ago (2015-03-22 04:23:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-22 08:10:32 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/86ebf48be903b226d068b08efa16fe3725babb8c Cr-Commit-Position: refs/heads/master@{#321711}
5 years, 9 months ago (2015-03-22 08:11:23 UTC) #9
Mostyn Bramley-Moore
Ryan (CC'ed) mentioned that NSS 3.14.3 support is still required for some product (but I'm ...
5 years, 9 months ago (2015-03-22 09:25:11 UTC) #11
sof
5 years, 9 months ago (2015-03-22 10:59:57 UTC) #12
Message was sent while issue was closed.
On 2015/03/22 09:25:11, Mostyn Bramley-Moore wrote:
> Ryan (CC'ed) mentioned that NSS 3.14.3 support is still required for some
> product (but I'm not sure which)- so we may need to revert this.

cf
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Linux%20Builder%20...
?

Powered by Google App Engine
This is Rietveld 408576698