Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1028833002: bluetooth: Enable device_unittests target on Android. (Closed)

Created:
5 years, 9 months ago by scheib
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Enable device_unittests target on Android. Initial configuration of GYP to enable building the device_unittests target. USB, Serial, and HID disabled as they currently do not compile, and are not blocking the dependent issues of this change (enabling Web Bluetooth). BUG=471536 Committed: https://crrev.com/b63d1ea55c453615dc19ab4212a4909d1580f79c Cr-Commit-Position: refs/heads/master@{#322889}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M build/all.gyp View 2 chunks +6 lines, -2 lines 0 comments Download
M device/device_tests.gyp View 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
scheib
5 years, 8 months ago (2015-03-29 01:34:05 UTC) #7
Reilly Grant (use Gerrit)
lgtm Can you update BUILD.gn as well if possible? I don't know if Android tests ...
5 years, 8 months ago (2015-03-29 06:53:46 UTC) #8
scheib
> Can you update BUILD.gn as well if possible? I don't know if Android tests ...
5 years, 8 months ago (2015-03-29 22:39:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028833002/80001
5 years, 8 months ago (2015-03-29 22:39:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52538)
5 years, 8 months ago (2015-03-29 22:47:00 UTC) #13
scheib
5 years, 8 months ago (2015-03-29 22:49:37 UTC) #15
scottmg
lgtm
5 years, 8 months ago (2015-03-30 16:30:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028833002/80001
5 years, 8 months ago (2015-03-30 21:53:15 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 8 months ago (2015-03-30 21:57:45 UTC) #19
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 21:59:36 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b63d1ea55c453615dc19ab4212a4909d1580f79c
Cr-Commit-Position: refs/heads/master@{#322889}

Powered by Google App Engine
This is Rietveld 408576698