Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1207)

Unified Diff: remoting/webapp/crd/js/desktop_connected_view.js

Issue 1028803002: [Chromoting] Convert VideoFrameRecorder into a proper protocol extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/crd/js/desktop_remoting.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/desktop_connected_view.js
diff --git a/remoting/webapp/crd/js/desktop_connected_view.js b/remoting/webapp/crd/js/desktop_connected_view.js
index af4a3fb55730612ef991c3f3f1ef4e60d7da0a5b..76af5725b0c4f0b1e9b21de7ab30175847f9e915 100644
--- a/remoting/webapp/crd/js/desktop_connected_view.js
+++ b/remoting/webapp/crd/js/desktop_connected_view.js
@@ -149,11 +149,6 @@ remoting.DesktopConnectedView.prototype.initPlugin_ = function() {
var sendCadElement = document.getElementById('send-ctrl-alt-del');
sendCadElement.hidden = true;
}
-
- if (this.session_.hasCapability(
- remoting.ClientSession.Capability.VIDEO_RECORDER)) {
- this.videoFrameRecorder_ = new remoting.VideoFrameRecorder(this.plugin_);
- }
};
/**
@@ -262,6 +257,12 @@ remoting.DesktopConnectedView.prototype.sendPrintScreen = function() {
this.plugin_.injectKeyCombination([0x070046]);
};
+/** @param {remoting.VideoFrameRecorder} recorder */
+remoting.DesktopConnectedView.prototype.setVideoFrameRecorder =
+ function(recorder) {
+ this.videoFrameRecorder_ = recorder;
+};
+
/**
* Returns true if the ClientSession can record video frames to a file.
* @return {boolean}
@@ -289,17 +290,3 @@ remoting.DesktopConnectedView.prototype.startStopRecording = function() {
this.videoFrameRecorder_.startStopRecording();
}
};
-
-/**
- * Handles protocol extension messages.
- * @param {string} type Type of extension message.
- * @param {Object} message The parsed extension message data.
- * @return {boolean} True if the message was recognized, false otherwise.
- */
-remoting.DesktopConnectedView.prototype.handleExtensionMessage =
- function(type, message) {
- if (this.videoFrameRecorder_) {
- return this.videoFrameRecorder_.handleMessage(type, message);
- }
- return false;
-};
« no previous file with comments | « no previous file | remoting/webapp/crd/js/desktop_remoting.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698