[Chromoting] Convert VideoFrameRecorder into a proper protocol extension.

remoting/webapp/crd/js/desktop_connected_view.js

Index: remoting/webapp/crd/js/desktop_connected_view.js
diff --git a/remoting/webapp/crd/js/desktop_connected_view.js b/remoting/webapp/crd/js/desktop_connected_view.js
index af4a3fb55730612ef991c3f3f1ef4e60d7da0a5b..81763d792b9e64df949194d68dbf56744af7278b 100644
--- a/remoting/webapp/crd/js/desktop_connected_view.js
+++ b/remoting/webapp/crd/js/desktop_connected_view.js
@@ -149,11 +149,6 @@ remoting.DesktopConnectedView.prototype.initPlugin_ = function() {
     var sendCadElement = document.getElementById('send-ctrl-alt-del');
     sendCadElement.hidden = true;
   }
-
-  if (this.session_.hasCapability(
-          remoting.ClientSession.Capability.VIDEO_RECORDER)) {
-    this.videoFrameRecorder_ = new remoting.VideoFrameRecorder(this.plugin_);
-  }
 };
 
 /**
@@ -262,6 +257,12 @@ remoting.DesktopConnectedView.prototype.sendPrintScreen = function() {
   this.plugin_.injectKeyCombination([0x070046]);
 };
 
+/** @param {remoting.VideoFrameRecorder} recorder */
+remoting.DesktopConnectedView.prototype.setVideoFrameRecorder =
+    function(recorder) {
+  this.videoFrameRecorder_ = recorder;
+};
+
 /**
  * Returns true if the ClientSession can record video frames to a file.
  * @return {boolean}
@@ -275,7 +276,7 @@ remoting.DesktopConnectedView.prototype.canRecordVideo = function() {
  * @return {boolean}
  */
 remoting.DesktopConnectedView.prototype.isRecordingVideo = function() {
-  if (!this.videoFrameRecorder_) {
+ if (!this.videoFrameRecorder_) {

[kelvinp, 2015/03/21 17:36:09]

Indent

[garykac, 2015/03/23 22:51:04]

Done.

     return false;
   }
   return this.videoFrameRecorder_.isRecording();
@@ -289,17 +290,3 @@ remoting.DesktopConnectedView.prototype.startStopRecording = function() {
     this.videoFrameRecorder_.startStopRecording();
   }
 };
-
-/**
- * Handles protocol extension messages.
- * @param {string} type Type of extension message.
- * @param {Object} message The parsed extension message data.
- * @return {boolean} True if the message was recognized, false otherwise.
- */
-remoting.DesktopConnectedView.prototype.handleExtensionMessage =

[Wez, 2015/03/20 23:53:40]

Not sure where this was even being called from under the new refactoring..?

[garykac, 2015/03/21 00:05:59]

It wasn't. The call was accidentally removed in a previous cl.

See the last change in:
https://codereview.chromium.org/1016623002/diff/80001/remoting/webapp/crd/js/...
to see the previous call site.

-    function(type, message) {
-  if (this.videoFrameRecorder_) {
-    return this.videoFrameRecorder_.handleMessage(type, message);
-  }
-  return false;
-};