Transitive inference using SCC

lib/src/options.dart

Index: lib/src/options.dart
diff --git a/lib/src/options.dart b/lib/src/options.dart
index cb7d88beb1591ab299b7fb71af99dacbdcdab1f1..f91da3171c502daf068deae427bd17255d89e214 100644
--- a/lib/src/options.dart
+++ b/lib/src/options.dart
@@ -46,7 +46,7 @@ class ResolverOptions {
   /// more detail so that, in the example above, we can use `B`'s inferred type
   /// always.

[vsm, 2015/03/21 15:52:19]

Can you update the comment?  :-)

Have you seen any noticeable analysis perf impact from turning this on?

[Siggi Cherem (dart-lang), 2015/03/23 20:06:31]

Good point. done.
I haven't noticed much change, no. I think it is because we still have a pretty
tight bound on how many times we analyze/resolve a piece of code.

Before this change we were analyzing every initializer twice:
  - once before inference
  - once more after inference
the latter was to improve codegen of the initializer expression given the new
types and to resolve portions of initializers that were skipped over at first,
like function expressions.

With this change, now we likely still do 2 passes over an initializer, but at
most 3 times:
  - once before inference
  - once after inferring the type of the dependencies
  - possibly once more if the initializer contained a function expression with a
body.

So I don't think we are adding that much more to what we were doing already.

   final bool inferTransitively;
-  static const inferTransitivelyDefault = false;
+  static const inferTransitivelyDefault = true;
 
   /// Restrict inference of fields and top-levels to those that are final and
   /// const.