Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1028773002: Revert of Percent height content should respect the fixed height of its containing cell (Closed)

Created:
5 years, 9 months ago by rhogan
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Percent height content should respect the fixed height of its containing cell (patchset #4 id:60001 of https://codereview.chromium.org/992483002/) Reason for revert: Broke Hangouts Original issue's description: > Percent height content should respect the fixed height of its containing cell > > When an element in a cell has a percent height and the cell has a fixed height we > currently let the element ignore the height on the cell and instead let its content > determine the height of the cell (and the row). > > Instead we should follow FF/Presto/Edge and the rendering agreed on the WG list > and let the element calculate itself as a percentage of its parent, the cell's > height. > > https://lists.w3.org/Archives/Public/www-style/2015Mar/0101.html > > BUG=465096 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192000 TBR=dsinclair@chromium.org,jchaffraix@chromium.org,leviw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=465096, 468699 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192275

Patch Set 1 #

Patch Set 2 : Updated #

Messages

Total messages: 4 (1 generated)
rhogan
Created Revert of Percent height content should respect the fixed height of its containing cell
5 years, 9 months ago (2015-03-20 18:49:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028773002/230001
5 years, 9 months ago (2015-03-20 19:09:04 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 19:10:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:230001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192275

Powered by Google App Engine
This is Rietveld 408576698