Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1028733002: Revert of Suppress MSI/MSM validation when building remoting MSI. (Closed)

Created:
5 years, 9 months ago by grt (UTC plus 2)
Modified:
5 years, 9 months ago
Reviewers:
garykac, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org, dxie
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Suppress MSI/MSM validation when building remoting MSI. (patchset #1 id:1 of https://codereview.chromium.org/1020823003/) Reason for revert: This did the trick. Reverting this change and putting something durable in the signing infrastructure. Thanks. Original issue's description: > Suppress MSI/MSM validation when building remoting MSI. > > I believe this will unblock a required migration in our signing > infrastructure. > > BUG=none > R=garykac@chromium.org > > Committed: https://crrev.com/819da16a0d1246383bb8fe3c483fe7ace98a60b7 > Cr-Commit-Position: refs/heads/master@{#321438} TBR=garykac@chromium.org,jamiewalch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/d4d4a120cdc230d725c6c781ff9c1793231df639 Cr-Commit-Position: refs/heads/master@{#321596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M remoting/host/installer/win/parameters.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
grt (UTC plus 2)
Created Revert of Suppress MSI/MSM validation when building remoting MSI.
5 years, 9 months ago (2015-03-20 17:53:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028733002/1
5 years, 9 months ago (2015-03-20 17:53:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 17:54:02 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 17:54:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d4d4a120cdc230d725c6c781ff9c1793231df639
Cr-Commit-Position: refs/heads/master@{#321596}

Powered by Google App Engine
This is Rietveld 408576698