Fix use of arraysize in GamepadProvider

Fix use of arraysize in GamepadProvider

Arraysize was being used for destination array sizes in memcpy and
memcmp, which returns the number of elements rather than the number of
bytes, as these functions expect. The result is that the entire arrays
were not getting copied.

BUG=469151
Committed: https://crrev.com/da87e71938a3aa652dd4a494ba0c22e28a67c948
Cr-Commit-Position: refs/heads/master@{#321587}

[kenrb, 2015-03-20 14:51:34]

kenrb@chromium.org changed reviewers:
+ scottmg@chromium.org

[kenrb, 2015-03-20 14:51:42]

kenrb@chromium.org changed required reviewers:
+ scottmg@chromium.org

[kenrb, 2015-03-20 14:52:00]

Scott: PTAL?

[inferno, 2015-03-20 15:13:26]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[inferno, 2015-03-20 15:13:27]

https://codereview.chromium.org/1028673002/diff/1/content/browser/gamepad/gam...
File content/browser/gamepad/gamepad_provider.cc (right):

https://codereview.chromium.org/1028673002/diff/1/content/browser/gamepad/gam...
content/browser/gamepad/gamepad_provider.cc:174: memcmp(id_, pad.id,
arraysize(id_) * sizeof(id_[0])) == 0 &&
why not just sizeof(id_) ? same at all other places ?

[inferno, 2015-03-20 15:24:52]

inferno@chromium.org changed reviewers:
+ b.kelemen@samsung.com

[kenrb, 2015-03-20 15:53:02]

https://codereview.chromium.org/1028673002/diff/1/content/browser/gamepad/gam...
File content/browser/gamepad/gamepad_provider.cc (right):

https://codereview.chromium.org/1028673002/diff/1/content/browser/gamepad/gam...
content/browser/gamepad/gamepad_provider.cc:174: memcmp(id_, pad.id,
arraysize(id_) * sizeof(id_[0])) == 0 &&
On 2015/03/20 15:13:26, inferno wrote:
> why not just sizeof(id_) ? same at all other places ?

I kind of like arraysize because it gives a compile error if you use it
incorrectly, but now that you point it out, it is much cleaner just to use
sizeof correctly.

[inferno, 2015-03-20 15:57:09]

lgtm

[inferno, 2015-03-20 16:19:53]

inferno@chromium.org changed reviewers:
+ bajones@chromium.org
- b.kelemen@samsung.com

[scottmg, 2015-03-20 16:36:26]

lgtm

[inferno, 2015-03-20 16:37:15]

The CQ bit was checked by inferno@chromium.org

[commit-bot: I haz the power, 2015-03-20 16:37:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1028673002/20001

[bajones, 2015-03-20 16:39:02]

bajones@chromium.org changed required reviewers:
- scottmg@chromium.org

[bajones, 2015-03-20 16:39:03]

lgtm

[commit-bot: I haz the power, 2015-03-20 17:27:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-20 17:27:51]

Patchset 2 (id:??) landed as
https://crrev.com/da87e71938a3aa652dd4a494ba0c22e28a67c948
Cr-Commit-Position: refs/heads/master@{#321587}