Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1028663002: Add a new GM to show problems with shear/rotate CTM w/ image filters. (Closed)

Created:
5 years, 9 months ago by Stephen White
Modified:
5 years, 9 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add a new GM to show problems with shear/rotate CTM w/ image filters. Committed: https://skia.googlesource.com/skia/+/d4bb991df84357ad77b7858ae6c5dd00347b7ba6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove call to canvas->clear() in onDraw(). #

Patch Set 3 : Win32 fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -0 lines) Patch
A gm/imagefilterstransformed.cpp View 1 2 1 chunk +124 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Stephen White
PTAL. This is just the GM from https://codereview.chromium.org/986623003/
5 years, 9 months ago (2015-03-20 14:31:12 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/1028663002/diff/1/gm/imagefilterstransformed.cpp File gm/imagefilterstransformed.cpp (right): https://codereview.chromium.org/1028663002/diff/1/gm/imagefilterstransformed.cpp#newcode64 gm/imagefilterstransformed.cpp:64: void onDraw(SkCanvas* canvas) SK_OVERRIDE { Is this necessary ...
5 years, 9 months ago (2015-03-20 14:35:40 UTC) #3
Stephen White
On 2015/03/20 14:35:40, robertphillips wrote: > lgtm > > https://codereview.chromium.org/1028663002/diff/1/gm/imagefilterstransformed.cpp > File gm/imagefilterstransformed.cpp (right): > ...
5 years, 9 months ago (2015-03-20 14:37:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028663002/20001
5 years, 9 months ago (2015-03-20 14:38:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/9)
5 years, 9 months ago (2015-03-20 15:13:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028663002/40001
5 years, 9 months ago (2015-03-20 15:31:31 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 15:54:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d4bb991df84357ad77b7858ae6c5dd00347b7ba6

Powered by Google App Engine
This is Rietveld 408576698