Issue 1028633006: Low-impact. Dispatcher now uses QuicServerSession, not QuicSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1028633006: Low-impact. Dispatcher now uses QuicServerSession, not QuicSession. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)

Modified:
5 years, 9 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Limit_send_algorithm_max_CWND_88747441

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Low-impact. Dispatcher now uses QuicServerSession, not QuicSession. This is a preparatory step for a group of upcoming changes with regards to Stateless Rejects. For stateless rejects, we'd like the dispatcher to access QuicServerSession server-specific information within the session. In order to do that, we need the dispatcher to contain a QuicServerSession object, rather than just a generic QuicSession object. Merge internal change: 88758328 R=rch@chromium.org

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -51 lines)			Patch
M	net/quic/quic_connection.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_dispatcher.h	View	5 chunks	+10 lines, -9 lines	0 comments	Download
M	net/quic/quic_dispatcher.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.h	View	5 chunks	+10 lines, -9 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher_test.cc	View	8 chunks	+38 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages