Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1028633005: Sync HTML element interfaces O-Q with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
vivekg, Jens Widell
CC:
blink-reviews, arv+blink, vivekg_samsung, blink-reviews-html_chromium.org, vivekg, dglazkov+blink, Inactive
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync HTML element interfaces O-Q with the spec Also fix the confused comment in HTMLImageElement, its hspace/vspace attributes should also be unsigned long, noticed now because of the same attributes on HTMLObjectElement. There are no changes to the generated code other than order. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192321

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : and P*, Q* #

Total comments: 1

Patch Set 4 : clear up HTMLImageElement confusion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -28 lines) Patch
M Source/core/html/HTMLImageElement.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOListElement.idl View 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +32 lines, -17 lines 0 comments Download
M Source/core/html/HTMLOptGroupElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/HTMLOptionElement.idl View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/html/HTMLOutputElement.idl View 1 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/html/HTMLParagraphElement.idl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLParamElement.idl View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M Source/core/html/HTMLPictureElement.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPreElement.idl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLProgressElement.idl View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLQuoteElement.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-21 18:33:42 UTC) #2
philipj_slow
oops
5 years, 9 months ago (2015-03-21 18:36:21 UTC) #3
Jens Widell
LGTM
5 years, 9 months ago (2015-03-21 18:38:38 UTC) #4
philipj_slow
and P*, Q*
5 years, 9 months ago (2015-03-21 18:44:20 UTC) #5
philipj_slow
Uh sorry, I didn't expect to get review so fast so I threw in some ...
5 years, 9 months ago (2015-03-21 18:45:44 UTC) #6
vivekg
lgtm https://codereview.chromium.org/1028633005/diff/40001/Source/core/html/HTMLImageElement.idl File Source/core/html/HTMLImageElement.idl (right): https://codereview.chromium.org/1028633005/diff/40001/Source/core/html/HTMLImageElement.idl#newcode23 Source/core/html/HTMLImageElement.idl:23: // FIXME: Most long types in this interfaces ...
5 years, 9 months ago (2015-03-22 02:27:03 UTC) #8
philipj_slow
clear up HTMLImageElement confusion
5 years, 9 months ago (2015-03-22 04:41:07 UTC) #9
philipj_slow
On 2015/03/22 02:27:03, vivekg_ wrote: > lgtm > > https://codereview.chromium.org/1028633005/diff/40001/Source/core/html/HTMLImageElement.idl > File Source/core/html/HTMLImageElement.idl (right): > ...
5 years, 9 months ago (2015-03-22 04:43:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028633005/60001
5 years, 9 months ago (2015-03-22 04:44:14 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53592)
5 years, 9 months ago (2015-03-22 06:28:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028633005/60001
5 years, 9 months ago (2015-03-22 09:55:13 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53607)
5 years, 9 months ago (2015-03-22 11:31:59 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028633005/60001
5 years, 9 months ago (2015-03-22 15:23:47 UTC) #21
commit-bot: I haz the power
5 years, 9 months ago (2015-03-22 17:10:41 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192321

Powered by Google App Engine
This is Rietveld 408576698