Autofill: Improve heuristics for city/state/zip fields.

components/autofill/core/browser/form_field.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/form_field.h"
 
 #include <stddef.h>
 #include <string>
 #include <utility>
 
@@ skipping 88 matching lines @@
 
   const AutofillField* field = scanner->Cursor();
 
   if (!MatchesFormControlType(field->form_control_type, match_type))
     return false;
 
   return MatchAndAdvance(scanner, pattern, match_type, match);
 }
 
 // static
+FormField::ParseNameLabelResult FormField::ParseNameAndLabelSeparately(

[Evan Stade, 2015/03/24 00:04:32]

do you anticipate using this for any other form field type

[Lei Zhang, 2015/03/25 00:42:28]

Not 100% sure, but I feel this may come in handy later.

+    AutofillScanner* scanner,
+    const base::string16& pattern,
+    int match_type,
+    AutofillField** match) {
+  if (scanner->IsEnd())
+    return RESULT_MATCH_NONE;
+
+  AutofillField* cur_match = nullptr;
+  size_t saved_cursor = scanner->SaveCursor();
+  bool parsed_name = ParseFieldSpecifics(scanner,
+                                         pattern,
+                                         MatchTypeWithoutLabel(match_type),
+                                         &cur_match);
+  scanner->RewindTo(saved_cursor);
+  bool parsed_label = ParseFieldSpecifics(scanner,
+                                          pattern,
+                                          MatchTypeWithoutName(match_type),
+                                          &cur_match);
+  if (parsed_name && parsed_label) {
+    if (match)
+      *match = cur_match;
+    return RESULT_MATCH_NAME_LABEL;
+  }
+
+  scanner->RewindTo(saved_cursor);
+  if (parsed_name)
+    return RESULT_MATCH_NAME;
+  if (parsed_label)
+    return RESULT_MATCH_LABEL;
+  return RESULT_MATCH_NONE;
+}
+
+// static
 bool FormField::ParseEmptyLabel(AutofillScanner* scanner,
                                 AutofillField** match) {
   return ParseFieldSpecifics(scanner,
                              base::ASCIIToUTF16("^$"),
                              MATCH_LABEL | MATCH_ALL_INPUTS,
                              match);
 }
 
 // static
 bool FormField::AddClassification(const AutofillField* field,
@@ skipping 82 matching lines @@
 
   if ((match_type & MATCH_PASSWORD) && type == "password")
     return true;
 
   if ((match_type & MATCH_NUMBER) && type == "number")
     return true;
 
   return false;
 }
 
+// static
+int FormField::MatchTypeWithoutLabel(int match_type) {
+  return match_type & ~MATCH_LABEL;

[Evan Stade, 2015/03/24 00:04:32]

just inline these two functions imo

[Lei Zhang, 2015/03/25 00:42:28]

Done.

+}
+
+// static
+int FormField::MatchTypeWithoutName(int match_type) {
+  return match_type & ~MATCH_NAME;
+}
+
 }  // namespace autofill