Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1028603004: Upstream ios/web/navigation (Closed)

Created:
5 years, 9 months ago by stuartmorgan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kkhorimoto
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios-testing
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream ios/web/navigation This directly upstreams the remainder of the ios/web/navigation folder, and a few supporting pieces. BUG=464810 Committed: https://crrev.com/271aab95144f3cb8dbf41e7a3bba829018a6dafc Cr-Commit-Position: refs/heads/master@{#322014}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase and resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4004 lines, -1 line) Patch
M ios/web/DEPS View 1 chunk +5 lines, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_certificate_policy_manager.h View 1 chunk +43 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_certificate_policy_manager.mm View 1 chunk +182 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_controller.h View 1 chunk +159 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_controller.mm View 1 chunk +874 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_controller+private_constructors.h View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_controller_unittest.mm View 1 chunk +1022 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_entry.h View 1 1 chunk +65 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_entry.mm View 1 1 chunk +318 lines, -0 lines 0 comments Download
A ios/web/navigation/crw_session_entry_unittest.mm View 1 1 chunk +400 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_item_facade_delegate.h View 1 chunk +31 lines, -0 lines 0 comments Download
M ios/web/navigation/navigation_item_impl.h View 1 5 chunks +42 lines, -0 lines 0 comments Download
M ios/web/navigation/navigation_item_impl.mm View 1 3 chunks +54 lines, -1 line 0 comments Download
A ios/web/navigation/navigation_manager_delegate.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_manager_facade_delegate.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_manager_impl.h View 1 chunk +147 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_manager_impl.mm View 1 chunk +251 lines, -0 lines 0 comments Download
A ios/web/navigation/navigation_manager_impl_unittest.mm View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/web/navigation/web_load_params.h View 1 chunk +60 lines, -0 lines 0 comments Download
A ios/web/navigation/web_load_params.mm View 1 chunk +42 lines, -0 lines 0 comments Download
M ios/web/public/navigation_item.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
A ios/web/public/web_state/page_scroll_state.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
A ios/web/public/web_state/page_scroll_state.mm View 1 1 chunk +72 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
stuartmorgan
Pure upstreaming
5 years, 9 months ago (2015-03-20 16:55:01 UTC) #2
stuartmorgan
+Kurt as FYI. Feel free to finish out your in-flight series downstream, and then we ...
5 years, 9 months ago (2015-03-20 16:56:28 UTC) #3
Eugene But (OOO till 7-30)
lgtm. Suggestions are optional https://codereview.chromium.org/1028603004/diff/1/ios/web/navigation/crw_session_controller.h File ios/web/navigation/crw_session_controller.h (right): https://codereview.chromium.org/1028603004/diff/1/ios/web/navigation/crw_session_controller.h#newcode30 ios/web/navigation/crw_session_controller.h:30: Not sure how far you ...
5 years, 9 months ago (2015-03-23 22:51:58 UTC) #4
stuartmorgan
Since SessionController and SessionEntry are deprecated, and will be folded into NavigationManager and NavigationItem, I'm ...
5 years, 9 months ago (2015-03-24 14:33:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028603004/20001
5 years, 9 months ago (2015-03-24 16:34:56 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 16:58:30 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 16:59:02 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/271aab95144f3cb8dbf41e7a3bba829018a6dafc
Cr-Commit-Position: refs/heads/master@{#322014}

Powered by Google App Engine
This is Rietveld 408576698