Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1028583002: Chromevox: kill braille translator log spam. (Closed)

Created:
5 years, 9 months ago by Peter Lundblad
Modified:
5 years, 9 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromevox: kill braille translator log spam. The message logging can be enabled by setting cvox.LibLouis.DEBUG to true. R=dtseng@chromium.org BUG=none Committed: https://crrev.com/783be28e270a9c1ba2b0439e281141e4a0f92d63 Cr-Commit-Position: refs/heads/master@{#322625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/braille/liblouis.js View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Peter Lundblad
5 years, 9 months ago (2015-03-27 15:29:54 UTC) #1
dmazzoni
lgtm Thanks! I've been meaning to try to kill some other log spam too, this ...
5 years, 9 months ago (2015-03-27 19:15:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028583002/1
5 years, 9 months ago (2015-03-27 19:16:17 UTC) #5
David Tseng
lgtm Thanks indeed! On Fri, Mar 27, 2015 at 12:15 PM, <dmazzoni@chromium.org> wrote: > lgtm ...
5 years, 9 months ago (2015-03-27 19:16:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 19:57:15 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 19:58:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/783be28e270a9c1ba2b0439e281141e4a0f92d63
Cr-Commit-Position: refs/heads/master@{#322625}

Powered by Google App Engine
This is Rietveld 408576698