Turn the utility process image decoder into a Mojo service.

chrome/browser/image_decoder.h

Index: chrome/browser/image_decoder.h
diff --git a/chrome/browser/image_decoder.h b/chrome/browser/image_decoder.h
index def5897d02636a6de6652786943901e53c5ed316..c9652d9231e357fee3f20e2c36f48c51e42f8e31 100644
--- a/chrome/browser/image_decoder.h
+++ b/chrome/browser/image_decoder.h
@@ -11,6 +11,7 @@
 
 #include "base/lazy_instance.h"
 #include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/sequence_checker.h"
 #include "base/sequenced_task_runner.h"
 #include "base/synchronization/lock.h"
@@ -20,6 +21,14 @@
 
 class SkBitmap;
 
+namespace image_decoder {
+class ImageDecoder;
+}
+
+namespace mojo {
+template <typename T> class InterfacePtr;
+}
+
 // This is a helper class for decoding images safely in a utility process. To
 // use this, call ImageDecoder::Start(...) or
 // ImageDecoder::StartWithOptions(...) on any thread.
@@ -150,6 +159,10 @@ class ImageDecoder : public content::UtilityProcessHostClient {
   // unless a new decoding request resets the timer.
   scoped_ptr<base::DelayTimer<ImageDecoder>> batch_mode_timer_;
 
+  // Mojo service connection. Must always be bound/reset and used on the IO
+  // thread.
+  scoped_ptr<mojo::InterfacePtr<image_decoder::ImageDecoder>> decoder_;

[Sam McNally, 2015/05/06 06:41:39]

Why a scoped_ptr?

[Anand Mistry (off Chromium), 2015/05/06 07:14:23]

Let me paraphrase Dorothy:
gyp, and gn, and deps! Oh my!

Or, put another way, using scoped_ptr<> lets me avoid depending on the generated
mojom header (or any part of Mojo) and leaking that dependency.

+
   DISALLOW_COPY_AND_ASSIGN(ImageDecoder);
 };