Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: components/image_decoder/image_decoder_impl.cc

Issue 1028543002: Turn the utility process image decoder into a Mojo service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4 #include "components/image_decoder/image_decoder_impl.h"
5
6 #include <string.h>
7
8 #include "base/logging.h"
9 #include "content/public/child/image_decoder_utils.h"
10 #include "ipc/ipc_channel.h"
11 #include "skia/ext/image_operations.h"
12 #include "skia/public/type_converters.h"
13 #include "third_party/skia/include/core/SkBitmap.h"
14 #include "ui/gfx/codec/jpeg_codec.h"
15 #include "ui/gfx/geometry/size.h"
16
17 namespace image_decoder {
18
19 namespace {
20 int64_t kMaxMessageSize = IPC::Channel::kMaximumMessageSize;
21 }
22
23 ImageDecoderImpl::ImageDecoderImpl(int64_t max_message_size)
24 : max_message_size_(max_message_size), binding_(this) {
25 }
26
27 ImageDecoderImpl::ImageDecoderImpl(mojo::InterfaceRequest<ImageDecoder> request)
28 : max_message_size_(kMaxMessageSize), binding_(this, request.Pass()) {
29 }
30
31 ImageDecoderImpl::~ImageDecoderImpl() {
32 }
33
34 void ImageDecoderImpl::DecodeImage(
35 mojo::Array<uint8_t> encoded_data,
36 ImageCodec codec,
37 bool shrink_to_fit,
38 const mojo::Callback<void(skia::BitmapPtr)>& callback) {
39 if (encoded_data.size() == 0) {
40 callback.Run(nullptr);
41 return;
42 }
43
44 SkBitmap decoded_image;
45 if (codec == IMAGE_CODEC_ROBUST_JPEG) {
46 // Our robust jpeg decoding is using IJG libjpeg.
47 if (gfx::JPEGCodec::JpegLibraryVariant() == gfx::JPEGCodec::IJG_LIBJPEG &&
48 encoded_data.size()) {
49 scoped_ptr<SkBitmap> decoded_jpeg(
50 gfx::JPEGCodec::Decode(&encoded_data[0], encoded_data.size()));
51 if (decoded_jpeg.get() && !decoded_jpeg->empty())
52 decoded_image = *decoded_jpeg;
53 }
54 } else {
55 decoded_image = content::DecodeImage(&encoded_data[0], gfx::Size(),
56 encoded_data.size());
57 }
58
59 if (!decoded_image.isNull()) {
60 skia::BitmapPtr dummy_image = skia::Bitmap::New();
61 int64_t struct_size = GetSerializedSize_(dummy_image);
62 int64_t image_size = decoded_image.computeSize64();
63 int halves = 0;
64 while (struct_size + (image_size >> 2 * halves) > max_message_size_)
65 halves++;
66 if (halves) {
67 if (shrink_to_fit) {
68 // If decoded image is too large for IPC message, shrink it by halves.
69 // This prevents quality loss, and should never overshrink on displays
70 // smaller than 3600x2400.
71 // TODO (Issue 416916): Instead of shrinking, return via shared memory
72 decoded_image = skia::ImageOperations::Resize(
73 decoded_image, skia::ImageOperations::RESIZE_LANCZOS3,
74 decoded_image.width() >> halves, decoded_image.height() >> halves);
75 } else {
76 decoded_image.reset();
77 }
78 }
79 }
80
81 if (decoded_image.isNull())
82 callback.Run(nullptr);
83 else
84 callback.Run(skia::Bitmap::From(decoded_image));
85 }
86
87 } // namespace image_decoder
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698