Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Issue 1028533004: Reset scroll status when a fling is ignored (Closed)

Created:
5 years, 9 months ago by jdduke (slow)
Modified:
5 years, 9 months ago
CC:
bokan, chromium-reviews, darin-cc_chromium.org, jam, jdduke+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset scroll status when a fling is ignored In WebView, flings that target the root scrolling layer are ignored by the compositor. In this case, we failed to clean up the scroll state in InputHandlerProxy, leading it to believe that a scroll was still active after the fling had been ignored. Handle this case, resetting the scroll activity bit when a fling is ignored. BUG=469369 Committed: https://crrev.com/cbee85393427388bf1e24919d4ff5b1a883c3e03 Cr-Commit-Position: refs/heads/master@{#321932}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M content/renderer/input/input_handler_proxy.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
jdduke (slow)
bokan@: PTAL, thanks.
5 years, 9 months ago (2015-03-21 01:21:08 UTC) #2
jdduke (slow)
+aelias for review (bokan@ to cc, sorry, but this appears to be interrupting WebView devs ...
5 years, 9 months ago (2015-03-24 01:16:13 UTC) #4
aelias_OOO_until_Jul13
lgtm
5 years, 9 months ago (2015-03-24 01:20:32 UTC) #5
jdduke (slow)
On 2015/03/24 01:20:32, aelias wrote: > lgtm thanks!
5 years, 9 months ago (2015-03-24 01:21:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028533004/20001
5 years, 9 months ago (2015-03-24 01:21:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/46361)
5 years, 9 months ago (2015-03-24 02:40:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028533004/20001
5 years, 9 months ago (2015-03-24 03:57:54 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 04:31:34 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 04:32:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbee85393427388bf1e24919d4ff5b1a883c3e03
Cr-Commit-Position: refs/heads/master@{#321932}

Powered by Google App Engine
This is Rietveld 408576698