Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 102853005: Add detection of mip support (Closed)

Created:
7 years ago by bsalomon
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add detection of mip support Committed: http://code.google.com/p/skia/source/detail?r=12771

Patch Set 1 #

Total comments: 3

Patch Set 2 : revert spew enabling #

Patch Set 3 : remove extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M src/gpu/GrDrawTarget.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/GrDrawTargetCaps.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +9 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
7 years ago (2013-12-18 22:09:46 UTC) #1
robertphillips
lgtm + 1 change request https://codereview.chromium.org/102853005/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/102853005/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode112 src/gpu/gl/GrGpuGL.cpp:112: Don't think we want ...
7 years ago (2013-12-19 14:24:33 UTC) #2
bsalomon
https://codereview.chromium.org/102853005/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/102853005/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode112 src/gpu/gl/GrGpuGL.cpp:112: On 2013/12/19 14:24:33, robertphillips wrote: > Don't think we ...
7 years ago (2013-12-19 15:03:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/102853005/40001
7 years ago (2013-12-19 15:03:51 UTC) #4
jvanverth1
One nit: https://codereview.chromium.org/102853005/diff/1/src/gpu/gl/GrGLCaps.cpp File src/gpu/gl/GrGLCaps.cpp (right): https://codereview.chromium.org/102853005/diff/1/src/gpu/gl/GrGLCaps.cpp#newcode300 src/gpu/gl/GrGLCaps.cpp:300: // to alllow arbitrary wrap modes, however. ...
7 years ago (2013-12-19 15:06:47 UTC) #5
jvanverth1
On 2013/12/19 15:06:47, JimVV wrote: > One nit: > > https://codereview.chromium.org/102853005/diff/1/src/gpu/gl/GrGLCaps.cpp > File src/gpu/gl/GrGLCaps.cpp (right): ...
7 years ago (2013-12-19 15:07:10 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-19 16:18:07 UTC) #7
Message was sent while issue was closed.
Change committed as 12771

Powered by Google App Engine
This is Rietveld 408576698