extensions/renderer/resources/guest_view/web_view/web_view_constants.js - Issue 1028503003: GuestView constants are now frozen (and thus actually constant).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/web_view/web_view_constants.js

Issue 1028503003: GuestView constants are now frozen (and thus actually constant). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js ('K') | « extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/web_view/web_view_constants.js

diff --git a/extensions/renderer/resources/guest_view/web_view/web_view_constants.js b/extensions/renderer/resources/guest_view/web_view/web_view_constants.js

index 23e2c872fc2ff07c62c9e045e389300d8300b2df..4bd2f3b15573b2e5967a023e4d9993456d43df1f 100644

--- a/extensions/renderer/resources/guest_view/web_view/web_view_constants.js

+++ b/extensions/renderer/resources/guest_view/web_view/web_view_constants.js

@@ -40,4 +40,6 @@ var WebViewConstants = {

'The permission request for "%1" has been denied.'

};

+Object.freeze(WebViewConstants);

Fady Samuel 2015/03/20 15:57:27 nit: $Object

paulmeyer 2015/03/20 16:16:15 Actually, $Object.freeze doesn't exist. I tried th

exports.WebViewConstants = WebViewConstants;

Fady Samuel 2015/03/20 15:57:27 You can save a couple of lines of code: exports.W

paulmeyer 2015/03/20 16:16:15 Done.