Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: extensions/renderer/resources/guest_view/extension_view/extension_view_constants.js

Issue 1028503003: GuestView constants are now frozen (and thus actually constant). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/web_view/web_view_constants.js » ('j') | extensions/renderer/resources/guest_view/web_view/web_view_constants.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This module contains constants used in extensionview. 5 // This module contains constants used in extensionview.
6 6
7 // Container for the extensionview constants. 7 // Container for the extensionview constants.
8 var ExtensionViewConstants = { 8 var ExtensionViewConstants = {
9 9 // Attributes.
10 ATTRIBUTE_EXTENSION: 'extension', 10 ATTRIBUTE_EXTENSION: 'extension',
11 ATTRIBUTE_SRC: 'src', 11 ATTRIBUTE_SRC: 'src',
12 }; 12 };
13 13
14 exports.ExtensionViewConstants = ExtensionViewConstants; 14 $Object.freeze(ExtensionViewConstants);
15
16 exports.ExtensionViewConstants = ExtensionViewConstants;
Fady Samuel 2015/03/20 15:57:27 You can save a couple of lines of code: exports.E
paulmeyer 2015/03/20 16:16:15 Done.
OLDNEW
« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/web_view/web_view_constants.js » ('j') | extensions/renderer/resources/guest_view/web_view/web_view_constants.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698