Don't show location bar in bookmark apps if there has been no navigation

chrome/browser/extensions/extension_ui_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_ui_util.h"
 
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
@@ skipping 61 matching lines @@
 bool ShouldShowLocationBar(const Extension* extension,
                            const content::WebContents* web_contents) {
   // Default to not showing the location bar if either |extension| or
   // |web_contents| are null. |extension| is null for the dev tools.
   if (!extension || !web_contents)
     return false;
 
   if (!extension->from_bookmark())
     return false;
 
+  // Don't show a location bar until a navigation has occurred.
+  if (web_contents->GetLastCommittedURL().is_empty())

[felt, 2015/03/23 20:41:56]

Can you test what happens here if you navigate to a page that shows a warning?

[benwells, 2015/03/24 05:14:59]

I've put a screenshot on the bug. Let me know if that is what you meant.

[felt, 2015/03/24 05:27:25]

Thanks, yes, that's what I meant. I wanted to check that the committed entry
wouldn't end up empty if you hit an interstitial on the first navigation, or
something weird like that.

+    return false;
+
   GURL launch_url = AppLaunchInfo::GetLaunchWebURL(extension);
   return !(IsSameOriginOrMoreSecure(launch_url,
                                     web_contents->GetVisibleURL()) &&
            IsSameOriginOrMoreSecure(launch_url,
                                     web_contents->GetLastCommittedURL()));
 }
 
 }  // namespace ui_util
 }  // namespace extensions