Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tools/testing/dart/multitest.dart

Issue 1028453002: Support percent encoded data URIs in the standalone embedder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: add negative tests, make multitest understand data uris, fix test in checked mode Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/tests/vm/dart/data_uri_spawn_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/multitest.dart
diff --git a/tools/testing/dart/multitest.dart b/tools/testing/dart/multitest.dart
index 3aed790d6fc096cfb39cfdfac36b5dc026574772..3d710921dc8d788cb18c8375e9b35168a437a1bc 100644
--- a/tools/testing/dart/multitest.dart
+++ b/tools/testing/dart/multitest.dart
@@ -73,7 +73,7 @@ void ExtractTestsFromMultitest(Path filePath,
final String line_separator =
(first_newline == 0 || contents[first_newline - 1] != '\r')
? '\n'
- : '\r\n';
+ : '\R\n';
Ivan Posva 2015/03/20 19:54:58 ?
rmacnak 2015/03/20 20:11:28 Unintentional.
List<String> lines = contents.split(line_separator);
if (lines.last == '') lines.removeLast();
bytes = null;
@@ -185,7 +185,7 @@ Set<String> _findAllRelativeImports(Path topLibrary) {
'^(?:@.*\\s+)?' // Allow for a meta-data annotation.
'(import|part)'
'\\s+["\']'
- '(?!(dart:|dart-ext:|package:|/))' // Look-ahead: not in package.
+ '(?!(dart:|dart-ext:|data:|package:|/))' // Look-ahead: not in package.
'([^"\']*)' // The path to the imported file.
'["\']');
while (!toSearch.isEmpty) {
« no previous file with comments | « runtime/tests/vm/dart/data_uri_spawn_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698