Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/ninja_script_target_writer.cc

Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/ppapi/ppapi_test.cc ('K') | « testing/android/native_test_util.cc ('k') | ui/base/accelerators/menu_label_accelerator_util_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_script_target_writer.cc
diff --git a/tools/gn/ninja_script_target_writer.cc b/tools/gn/ninja_script_target_writer.cc
index 97f25525689503d861ae2308e807546b26a8dfd7..f2004e3303e7c22a07114591d1170597daac6911 100644
--- a/tools/gn/ninja_script_target_writer.cc
+++ b/tools/gn/ninja_script_target_writer.cc
@@ -72,7 +72,7 @@ std::string NinjaScriptTargetWriter::WriteRuleDefinition(
// there will be only one invocation so we can use a simple name.
std::string target_label = target_->label().GetUserVisibleName(true);
std::string custom_rule_name(target_label);
- ReplaceChars(custom_rule_name, ":/()", "_", &custom_rule_name);
+ base::ReplaceChars(custom_rule_name, ":/()", "_", &custom_rule_name);
custom_rule_name.append("_rule");
if (settings_->IsWin()) {
« chrome/test/ppapi/ppapi_test.cc ('K') | « testing/android/native_test_util.cc ('k') | ui/base/accelerators/menu_label_accelerator_util_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698