chrome/browser/shell_integration_linux.cc - Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/shell_integration_linux.cc

Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/search_engines/template_url_service.cc ('k') | chrome/browser/tab_contents/render_view_context_menu.cc » ('j') | chrome/test/ppapi/ppapi_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/shell_integration_linux.cc

diff --git a/chrome/browser/shell_integration_linux.cc b/chrome/browser/shell_integration_linux.cc

index 61a0092a7ea338420a66aed5d32706575045c1d8..ad1a65aff7dec39e1ba37cc12adf5880f7816aa8 100644

--- a/chrome/browser/shell_integration_linux.cc

+++ b/chrome/browser/shell_integration_linux.cc

@@ -680,7 +680,7 @@ base::FilePath GetExtensionShortcutFilename(const base::FilePath& profile_path,

file_util::ReplaceIllegalCharactersInPath(&filename, '_');

// Spaces in filenames break xdg-desktop-menu

// (see https://bugs.freedesktop.org/show_bug.cgi?id=66605).

- ReplaceChars(filename, " ", "_", &filename);

+ base::ReplaceChars(filename, " ", "_", &filename);

return base::FilePath(filename.append(".desktop"));

}

@@ -696,7 +696,7 @@ std::vector<base::FilePath> GetExistingProfileShortcutFilenames(

file_util::ReplaceIllegalCharactersInPath(&suffix, '_');

// Spaces in filenames break xdg-desktop-menu

// (see https://bugs.freedesktop.org/show_bug.cgi?id=66605).

- ReplaceChars(suffix, " ", "_", &suffix);

+ base::ReplaceChars(suffix, " ", "_", &suffix);

std::string glob = prefix + "*" + suffix + ".desktop";

base::FileEnumerator files(directory, false, base::FileEnumerator::FILES,