chrome/browser/chromeos/system/syslogs_provider.cc - Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/system/syslogs_provider.cc

Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/hwid_checker.cc ('k') | chrome/browser/component_updater/pnacl/pnacl_component_installer.cc » ('j') | chrome/test/ppapi/ppapi_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/system/syslogs_provider.cc

diff --git a/chrome/browser/chromeos/system/syslogs_provider.cc b/chrome/browser/chromeos/system/syslogs_provider.cc

index 5cbba5dcff86a6fd4aab50b299b0100b27b1f75b..3b38b808ae42ea59dc2bf71c1e84c284dc979b10 100644

--- a/chrome/browser/chromeos/system/syslogs_provider.cc

+++ b/chrome/browser/chromeos/system/syslogs_provider.cc

@@ -79,7 +79,7 @@ std::string ReadValue(std::string* data) {

// If we use TrimWhitespace, we will incorrectly trim the new line

// and assume that KEY1's value is "KEY2=VALUE" rather than empty.

- TrimString(*data, " \t", data);

+ base::TrimString(*data, " \t", data);

// If multiline value

if (StartsWithASCII(*data, std::string(kMultilineQuote), false)) {