Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1028413002: Revert of [V8] Removed SourceLocationRestrict (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
Reviewers:
kozy, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [V8] Removed SourceLocationRestrict (patchset #3 id:40001 of https://codereview.chromium.org/1022333004/) Reason for revert: [Sheriff] This seems to change layout test expectations of some tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2317 Expectation example: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/2317/layout-test-results/fast/events/window-onerror-11-pretty-diff.html Please add a needsmanualrebaseline expectation to the tests affected by this change on the blink side first before relanding. Original issue's description: > [V8] Removed SourceLocationRestrict > > This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it. > Method looks obsolete. > One of the strange side effect is shown by attached issue. > > BUG=chromium:468781 > R=yangguo@chromium.org > LOG=Y > > Committed: https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf > Cr-Commit-Position: refs/heads/master@{#27374} TBR=yangguo@chromium.org,kozyatinskiy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468781 Committed: https://crrev.com/310d75218ed75cfe50d24c1fee0215a391247a74 Cr-Commit-Position: refs/heads/master@{#27398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -4 lines) Patch
M src/messages.js View 4 chunks +54 lines, -0 lines 0 comments Download
M test/mjsunit/debug-sourceinfo.js View 2 chunks +89 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [V8] Removed SourceLocationRestrict
5 years, 9 months ago (2015-03-24 12:04:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028413002/1
5 years, 9 months ago (2015-03-24 12:04:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 12:04:43 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 12:04:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/310d75218ed75cfe50d24c1fee0215a391247a74
Cr-Commit-Position: refs/heads/master@{#27398}

Powered by Google App Engine
This is Rietveld 408576698