Issue 1028403002: Revert "Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview.chromium.…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1028403002: Revert "Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview.chromium.… (Closed)

Created:
5 years, 9 months ago by reed2

Modified:
5 years, 9 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert "Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview.chromium.org/967943002/)" disabled for the momment -- need to understand arm64 glitches This reverts commit 374a4c3b744e8c77455efa73b139950136f7b374. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/b67eb2f9b9ec097aa963245a85be13daec09d2cc

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -32 lines)			Patch
M	gm/colormatrix.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	include/effects/SkColorMatrix.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	include/effects/SkColorMatrixFilter.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	4 chunks	+128 lines, -29 lines	0 comments	Download

Total messages: 3 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1028403002/1

5 years, 9 months ago (2015-03-24 11:06:32 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-24 11:13:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b67eb2f9b9ec097aa963245a85be13daec09d2cc